Files disappeared into Limbo with .bat file

[MemeMaestro]

So the thing is, I built myself a .bat file to clean up my entire desktop with one click. I then executed said file and was dumb enough to immediately do so on the desktop rather than testing it in a seperate folder first. Then, as the title suggested, disaster struck and while the folder was created correctly, it ended up empty and all my files are gone and I don't know where they went. I am hoping that someone may be able to tell me where they are, help me get them back, or just deliver the bad news that they're lost in Limbo forever.

Here's the code in question:

@echo off

set "data_folder=%UserProfile%\Desktop\DATA"

if not exist "%data_folder%" (
    mkdir "%data_folder%"
) else (
    echo Ordner %data_folder% existiert bereits.
)

for %%A in ("%UserProfile%\Desktop*") do (
    if not "%%~xA"=="" (
        set "type_folder=%data_folder%%%~xA"
        if not exist "%type_folder%" mkdir "%type_folder%"
        move "%%~A" "%type_folder%"
    )
)

echo Done!
pause

Note that I have since fixed the code and it is now working as intended. Though my files are still lost.

 

[Deleted member 2829]

The code shown here does not delete any files. I guess in your original bat file you used the DEL command ? Then the files have been permanently deleted, as the DOS command line does not use the Recycle Bin. But of course you have a backup so all should be ok, right ?

Note that deleting a file only deletes the file headers (the names, so to speak), not the file contents. You might be able to recover them using one of the several available undelete utilities. But you need to be quick, before any of the freed disk space (still containing the old data) is going to be reused by new files.

This reminds me of the day I created a handy UNIX script that would loop through a directory, for each file asking whether to delete it or not. I tested it on my user directory, duly answering NO for each file. After the script finished, I found to my dismay that all the files were gone. Turned out I had the yes/no test programmed the other way round 😮 I don't remember if I got them back and how, it was a long time ago.

 

[MemeMaestro]

The code shown here does not delete any files. I guess in your original bat file you used the DEL command ? Then the files have been permanently deleted, as the DOS command line does not use the Recycle Bin. But of course you have a backup so all should be ok, right ?

Note that deleting a file only deletes the file headers (the names, so to speak), not the file contents. You might be able to recover them using one of the several available undelete utilities. But you need to be quick, before any of the freed disk space (still containing the old data) is going to be reused by new files.

I didn't use the Del command. The code seen is the code I exectued when the files disappeared.

I'll try the undelete idea tomorrow regardless and perhaps let you know how it went

 

[Deleted member 2829]

I didn't use the Del command. The code seen is the code I exectued when the files disappeared.

I'll try the undelete idea tomorrow regardless and perhaps let you know how it went

Oh right. Then it looks you have been renaming each file to the same name, which is nearly as good as deleting them all.
I have to say I've no actual experience with undelete utilities... I prefer making regular backups (which I hope you'll start to do from now on too).
Do let know how you fare with an undelete program. I wouldn't hold my breath though.