Welcome!

By registering with us, you'll be able to discuss, share and private message with other members of our community.

SignUp Now!
  • Guest, before posting your code please take these rules into consideration:
    • It is required to use our BBCode feature to display your code. While within the editor click < / > or >_ and place your code within the BB Code prompt. This helps others with finding a solution by making it easier to read and easier to copy.
    • You can also use markdown to share your code. When using markdown your code will be automatically converted to BBCode. For help with markdown check out the markdown guide.
    • Don't share a wall of code. All we want is the problem area, the code related to your issue.


    To learn more about how to use our BBCode feature, please click here.

    Thank you, Code Forum.

JavaScript Help combining two functions

jack

New Coder
Hi,
I have these two functions which have mostly similar code.. so I want to combine them into one function.. any help appreciated.

JavaScript:
previousMonthImg.onclick = function() {
    if (!(monthSelect.value === "Jan" && yearSelect.value === "2010")) {
        monthSelect.selectedIndex--;
        if (monthSelect.selectedIndex === -1) {
            monthSelect.value = "Dec";
            yearSelect.selectedIndex--;
        }
    }
    triggerEvent(monthSelect, "change");
    triggerEvent(yearSelect, "change");
};

JavaScript:
nextMonthImg.onclick = function() {
    if (!(monthSelect.value === "Dec" && yearSelect.value === "2030")) {
        monthSelect.selectedIndex++;
        if (monthSelect.selectedIndex === -1) {
            monthSelect.value = "Jan";
            yearSelect.selectedIndex++;
        }
    }
    triggerEvent(monthSelect, "change");
    triggerEvent(yearSelect, "change");
}
 
Honestly, looking at these two functions they are pretty similar, but have one key difference: The first one subtracts values and the second one adds to them. You could combine them into one big function, but then you have to do a bunch of if checks to see if you are incrementing or decrementing the value. You also have to then keep track of whether the user clicked the previous or next month image.

I would recommend maybe making a third function called activateCalendarTriggers that has the triggerEvent() code in it and call that function from both of these functions. That may be the cleaner solution as you'll be extracting out the code that is the same while keeping the code that is different in separate functions.
 

Buy us a coffee!

Back
Top Bottom