Python What's an alternate solution to building a pyramid?

[choppingbl0ck]

This is what I have so far. I'm told it's not acceptable. Any ideas on a different way to do this? I have to use loops

def print_pyramid(str,h):
    if str=="right":
        for i in range(h):
            print('#' * (i+1))
 
    elif str=="left":
        for i in range(h):
            print(' '*(h-i) + '#'*(i+1))
    elif str=="both":
        for i in range(h):
            print(' '*(h-i-1) + '#'*(2*i))

Here is the question

 

[skifli]

This is what I have so far. I'm told it's not acceptable. Any ideas on a different way to do this? I have to use loops

def print_pyramid(str,h):
    if str=="right":
        for i in range(h):
            print('#' * (i+1))
 
    elif str=="left":
        for i in range(h):
            print(' '*(h-i) + '#'*(i+1))
    elif str=="both":
        for i in range(h):
            print(' '*(h-i-1) + '#'*(2*i))

Here is the question

I do not think there is necessarily anything wrong with the way your code functions. More, it is probably the way it is written. First, you use `str` as a variable. NEVER USE the same names for variables that Python uses. Python uses `str` for the type string, and for the function converting to a string. I would recommend using `alignment`. Second, you use undescriptive variable names in the for loops. You should always use descriptive variable names to make it easier for someone else to understand what your program is doing, like `index`. Thirdly (and this is more of a picky point), but I would recommend using type hinting so someone looking at your code knows what type the arguments are.

def print_pyramid(alignment: str, height: int) -> None:
    if alignment == "right":
        for index in range(height):
          print(“#” * (index + 1))

   elif alignment == "left":
      for index in range(height):
         print(“” * (height - index) + “#” * (index + 1))

   elif alignment == "both":
      for index in range(height):
         print(“ “ * (height – index - 1) + “#” * (2 * index))