PHP email subject line

[MyeGarage]

First timer here and I DID read the rules first. I also have burned hours searching for my answer to no avail. I think I am very close. I don't create php code yet, but I can modify existing code usually to fit my needs, most of the time, so that is where I am coming from.

The problem involves the subject line in my email module. Here is the code:

$subject = "Repair log for ".$vehicleInfo[0]->year;' '.$vehicleInfo[0]->make;' '.$vehicleInfo[0]->model;' '.$vehicleInfo[0]->lic_plate;

When the email arrives the subject line reads the text and only one variable (year). I use the same code in the body of the email and it displays perfect, so the mechanics of the code appears to be fine. Is there a limit on characters in the subject line or is it something else?
any direction would be much appreciated!
I'll keep searching.........

 

[Deleted member 2829]

The very first semicolon (the one after year) ends the assignment to $subject. Not sure what PHP does with the remainder of the line, but surely it does not end up in $subject. If you replace all semicolons (except the last one of course) by dots it will work:

$subject = "Repair log for ".$vehicleInfo[0]->year.' '.$vehicleInfo[0]->make.' '.$vehicleInfo[0]->model.' '.$vehicleInfo[0]->lic_plate;

Quite an ugly construction though. I'm not a PHP buff but I think there may be better ways to format a string.

 

[MyeGarage]

thanks! that was it. I couldn't tell you pretty code from ugly code, but I know when it works!

 

[Deleted member 2829]

$subject = "Repair log for {$vehicleInfo[0]->year}  {$vehicleInfo[0]->make}  {$vehicleInfo[0]->model}  {$vehicleInfo[0]->lic_plate}";

This also works. You'll have to admit it is a lot prettier 😁

 

[MyeGarage]

cleaner too!

 

[Deleted member 2829]

You would not need the curly brackets if it were not for the -> operators. But you could do this:

$year      = vehicleInfo[0]->year;
$make      = vehicleInfo[0]->make;
$model     = vehicleInfo[0]->model;
$lic_plate = vehicleInfo[0]->lic_plate;
$subject   = "Repair log for $year $make $model $lic_plate";