C# Any tips to improve this code?

[TheUninvited]

So basically i've been trying to convert sublime snippets to visual studio. So far i created this to grab all the snippets inside the sublime text and i am wondering if there's any way to improve the way of finding the elements in the for loop? My code works you know but to me i am trying to make this converter for training and learning purposes i know there is a snippet designer out there i can probably just do everything with my hands and i can still be fine it would take less time than trying to copy and paste my snippets from sublime. But still i just thought why not do this Here is the code and video :

The code:

 public void regexReplaceSublimeParameters(int num, List<string> mylist)
    {    
         
      Regex maxReg = new Regex(@"(\${)" + num + @"(.*?)(?=})");
      Match maxMatch = maxReg.Match(subInText);

for (int i = 0; i < ReturnCounter(); i++)
      {
        if (maxMatch.Success)
        {
          maxReg = new Regex(@"(\${)" + num + @"(.*?)(?=})");
          maxMatch = maxReg.Match(subInText);
          mylist.Add(maxMatch.Value);
          num++;
        }          
      }

foreach (string list in mylist)
      {
        Console.WriteLine(list);
      }
  }


    public int ReturnCounter()
    {
     
      Regex maxReg = new Regex(@"(\${)" + counter + @"(.*?)(?=})");
      Match maxMatch = maxReg.Match(subInText);

      while (maxMatch.Success)
      {
     
        if (!maxMatch.Success)
        {
          break;
        }
        else
        {
          counter++;
          maxReg = new Regex(@"(\${)" + counter + @"(.*?)(?=})");
          maxMatch = maxReg.Match(subInText);
        }
       
      }

     
      return counter;

    }

The video:

To view this content we will need your consent to set third party cookies.
For more detailed information, see our cookies page.

Accept third party cookies

 

[Krusty the Senile]

Sorry if I wasn't clear in my previous suggestion, but it's possible to create a regular expression that will capture all the elements from the input text and give you back a collection. The Regex Class documentation on the Microsoft website (https://docs.microsoft.com/en-us/do...egularexpressions.regex?view=netframework-4.8) gives an example of how to do this, using the Regex.Matches() function. The regex I suggested in your other post will give you that collection. The advantage of this approach is that you won't need to create a specific regex with unique integer to match every integer value in the input text.

 

[Malcolm]

I think you could start with comments e.g. how does the code work, and what does it do.

Documentation is key, it helps you and others remember what does what.

 

[Dan-Kode]

I strongly agree with, @Malcolm, on this one.

Comments and Documenting your Code is essential and it helps you to remember what you're doing and it let's others know what a part of your Code does and what it's for.

 

[Malcolm]

What programming language is this, @TheUninvited?

 

[Dan-Kode]

I'm 100% sure it's C#, judging by the Keywords.

C# uses things like Console.WriteLine().

 

[Malcolm]

Awesome thank you. I'll move this to appropriate forum now

 

[Dan-Kode]

You're welcome.

 

[TheUninvited]

What programming language is this, @TheUninvited?

indeed c# always no time for other languages

Unity3d is also c# so works fine

 

[Brad]

Chuck your code inside of a class then declare the regex at the top so you don't have to keep doing Regex regex and in your while loop you don't need the else statement, you can get away with just:

public int ReturnCounter()
{
      Regex maxReg = new Regex(@"(\${)" + counter + @"(.*?)(?=})");
      Match maxMatch = maxReg.Match(subInText);

      while (maxMatch.Success)
      {
        if (!maxMatch.Success)
        {
          break;
        }
        // Do not need else, break stops the execution there...
        counter++;
        maxReg = new Regex(@"(\${)" + counter + @"(.*?)(?=})");
        maxMatch = maxReg.Match(subInText);
        
      }

    
      return counter;

}