JavaScript Greeting with day of the week

[nebmucoy674]

Why is this JS not showing the appropriate greeting? I'm new to this, but I thought the getDay() would result in 0-6, with 0 and 6 being weekend, resulting in the appropriate greeting. Thank you!

<p id="weekday"></p>
<script>
const day = new Date().getDay();
let greeting;

if (day = 0) {
  greeting = "Happy Weekend";
} else if (day = 6) {
  greeting = "Happy Weekend";
} else {
  greeting = "Happy Weekday";
}
document.getElementById("weekday").innerHTML = greeting;
</script>

 

[Deleted member 2829]

Perhaps the most common beginning programmer's mistake is using = (which is an assignment) instead of == (which is a comparison). For example the expression day = 6 assigns six to day, and returns 6 as the result, so that if (day = 6) always yields true, whatever the value assigned.
I would suggest using a switch statement instead of a cascade of if's.

Edit:
You would have seen the problem had you pressed F12 and looked in the console output, where it says
Uncaught TypeError: Assignment to constant variable.
Because day is defined as const, and the statement if (day = 0) tries to assign the value zero to it, as explained above.

Advice: Whenever some JS does not work as (you think) it should, press F12 and check the console output.

 

[Johna]

You can reduce the amount of code you have by using || which means 'or'.
So like, if day = 0 or day = 6, then say happy weekend:

<p id="weekday"></p>
<script>
const day = new Date().getDay();
let greeting;

if (day == 0 || day == 6) {
  greeting = "Happy Weekend";
} else {
  greeting = "Happy Weekday";
}
document.getElementById("weekday").innerHTML = greeting;
</script>