Python Need help with python calculator issue (bug?)

[User8574]

I typed in this code

operator = input("Choose an operator (1 = Add, 2 = Subtract, 3 = Divide, 4 = Multiply) ")
first = input("Enter an integer ")
second = input("Enter a second integer ")

if operator == 1:
    result = (float(first) + float(second))

elif operator == 2:
    result = (float(first) - float(second))

elif operator == 3:
    result = (float(first) / float(second))

else:
    result = (float(first) * float(second))

print(result)

And when I choose 1, 2 or 3, it still multiplies. Anyone knows why?
I am a very inexperienced coder btw.

 

[skifli]

You need to convert the user's choice into an integer. Since the user's choice is a str, none of the if statements are fulfilled and it runs the code in the else statement. I have improved your code a bit as well.

operator = int(input("Choose an operator (1 = Add, 2 = Subtract, 3 = Divide, 4 = Multiply) "))
first = float(input("Enter an integer "))
second = float(input("Enter a second integer "))

if operator == 1:
    result = first + second

elif operator == 2:
    result = first - second

elif operator == 3:
    result = first / second

else:
    result = first * second

print(result)

 

[simong1993]

didlly is correct but at the same time, you have caused a new issues mate 😀 By changing the input to a int you now have the issue of, what if someone does input a string. What I would do is this :-

operator = input("Choose an operator (1 = Add, 2 = Subtract, 3 = Divide, 4 = Multiply) ")
first = 0
second = 0

while True:
    try:
        first = float(input("Enter an integer "))
        break
    except:
        print("First must be a digit and not a letter")
        continue

while True:
    try:
        second = float(input("Enter a second integer "))
        break
    except:
        print("Second must be a digit and not a letter")
        continue

if operator == "1":
    result = first + second

elif operator == "2":
    result = first - second

elif operator == "3":
    result = first / second

else:
    result = first * second

print(result)

So with my code, we do not change the string to int but instead, we check a string against a string, this stops one of the errors. then we do a loop of first and second. we use a try and except and when we have a int or float we move on 😀

 

[racheal]

You'll need to turn the user's selection into an integer. Because the user's selection is a str, none of the if statements are true, and the code in the otherwise statement is executed. I've also made some changes to your code.