sometimes doesnt work

[faltu]

Write a programme for estimation of the S value = n i=1 ∑ 1/ (ki) 2 + 1
Note: n as integer value and element values of k as float type should be taken from users


Sometimes when I give n the value 8 or a different value it asks for more than n values for k

my code:

#include <stdio.h>




int main()
{
    int i,n;
    float k,total;
   
   

    printf("enter a value for n: ");
    scanf("%d",&n);
    total=0;
    for(i=1;i<=n;i++)
    {
        for(k=i;k<=i;k++)
        {
            printf("enter values for k:");
            scanf("%f",&k);
            total=total+1/(k*k+1);

        }
    }
   
   

    printf("result = %f\n",total);
    return 0;
   
}

 

[Deleted member 2829]

Your inner loop is borked... Twice, actually. First, you have

for (k=i; k<=i; k++)

which will run only once (for the value k == i). Perhaps you meant to start the loop with k=1 rather than k=i ?
But even then it would not work, because inside the loop you set the value of k to whatever you typed in, making it impossible to predict what the loop will do. As a rule, you don't modify a loop variable inside the loop (except maybe when you want to skip ahead or backward).

I don't understand why you have this inner loop anyway. You are just making things difficult for no good reason.
I think when you remove that inner loop altogether your program will just work fine :

for ( i=1; i<=n; i++)
{
    printf("enter values for k:");
    scanf("%f", &k);
    total += 1/(k*k+1);
}

Note, I added some spaces here and there. Makes it easier to understand and spot nifty errors like using i instead of 1.
HTH

 

[faltu]

I understand that you meant to say thank you very much for your answer .

 

[Deleted member 2829]

I understand that you meant to say thank you very much for your answer .

Does it work now ?

 

[faltu]

Does it work now ?

yes