What I'm missing here?

[xanderbilla]

//Inserting value at the end

#include <stdio.h>

void main()
{
    int i, upper_bound, n, value, arr[10] = {10,20};

    n = sizeof(arr)/sizeof(arr[0]);

    printf("Please give upperbound value: ");
    scanf("%d", &upper_bound);

    for (i = upper_bound+1; upper_bound == n ;i++)
    {
        printf("Please give a number to insert at end: ");
        scanf("%d", &value);
        arr[i] = value;
    }
}

 

[Deleted member 2829]

Bit of a strange term, inserting at the end. Adding to the end is not inserting but appending. The act of inserting involves moving array element forward to make room, which I don't see happening here. Actually it seems you are just filling the array starting with a specified index.

Anyway, look at the end condition in your for loop : upper_bound == n. This is ether false or true, and never changes (because upper-bound and n do no change). So either you never go into the loop of you go into it but never get out. Either way, not good. You may want to re-think what you are doing there. Didn't you just mean to write i < n instead ? Assuming that upper_bound is less than n. If not your program will likely crash.

It seems unusual to define an array with 10 elements but initialize with only two element. And then calculate the number of elements by using sizeof. Did you check the calculated value of n is 10 as you probably would expect ?

Lastly, at the end of the program, would you not print the entire array to check that everything is correct ?